Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

geo/geomfn: implement Intersection, PointOnSurface, Union #49833

Merged
merged 1 commit into from
Jun 4, 2020
Merged

geo/geomfn: implement Intersection, PointOnSurface, Union #49833

merged 1 commit into from
Jun 4, 2020
+581 −126

Conversation

otan
Copy link
Contributor

@otan otan commented Jun 3, 2020

The last of the topology operators up to Chapter 20.

Resolves #48951
Resolves #49832
Resolves #49064

Release note (sql change): Implements the ST_Intersection,
ST_PointOnSurface and ST_Union builtin functions.

@otan otan requested review from sumeerbhola and a team June 3, 2020 15:38
@cockroach-teamcity
Copy link
Member

This change is Reviewable

sumeerbhola
sumeerbhola approved these changes Jun 4, 2020
View reviewed changes
Copy link
Collaborator

@sumeerbhola sumeerbhola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 11 of 11 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@rmloveland
Copy link
Collaborator

Hey Oliver, Chapter 20 of what? Wanna add to my list of things to review.

@otan
Copy link
Contributor Author

otan commented Jun 4, 2020

@rmloveland chapter 20 of the PostGIS tutorial :)

@otan
Copy link
Contributor Author

otan commented Jun 4, 2020

bors r=sumeerbhola

@craig
Copy link
Contributor

craig bot commented Jun 4, 2020

Merge conflict (retrying...)

@otan
Copy link
Contributor Author

otan commented Jun 4, 2020

bors r-

@craig
Copy link
Contributor

craig bot commented Jun 4, 2020

Canceled

@otan
geo/geomfn: implement Intersection, PointOnSurface, Union
6496403 
The last of the topology operators up to Chapter 20.

Release note (sql change): Implements the ST_Intersection,
ST_PointOnSurface and ST_Union builtin functions.
@otan otan force-pushed the three_more_builtins branch from c47eeca to 6496403 Compare June 4, 2020 18:29
@otan
Copy link
Contributor Author

otan commented Jun 4, 2020

bors r=sumeerbhola

@craig
Copy link
Contributor

craig bot commented Jun 4, 2020

Build succeeded

@craig craig bot merged commit 67252bc into cockroachdb:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumeerbhola sumeerbhola sumeerbhola approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@otan @cockroach-teamcity @rmloveland @sumeerbhola